Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy entry content on Ctrl+C #244

Merged
merged 5 commits into from
Mar 12, 2023
Merged

Copy entry content on Ctrl+C #244

merged 5 commits into from
Mar 12, 2023

Conversation

lenemter
Copy link
Member

Resolves #218

@lenemter lenemter requested a review from a team March 12, 2023 11:02
@lenemter lenemter mentioned this pull request Mar 12, 2023
Open
jeremypw
jeremypw approved these changes Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Behaviour similar to Gnome Calculator - i.e. the copied text is not selected when copying without a selection.

@jeremypw jeremypw merged commit 51dcc8b into master Mar 12, 2023
@jeremypw jeremypw deleted the copy branch March 12, 2023 15:44
BAProductions pushed a commit to MC-OS/calculator that referenced this pull request Mar 12, 2023
@lenemter @BAProductions
Revert "Copy entry content on Ctrl+C (elementary#244)"
7c40d44 
This reverts commit 51dcc8b.
BAProductions pushed a commit to MC-OS/calculator that referenced this pull request Mar 13, 2023
@lenemter @BAProductions
Revert "Revert "Copy entry content on Ctrl+C (elementary#244)""
d41d37c 
This reverts commit 7c40d44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ctrl+C should copy display contents to clipboard
2 participants
@lenemter @jeremypw